perf: performance improvements MTT-4641 #2176#2204
Merged
jeffreyrainy merged 10 commits intodevelopfrom Sep 23, 2022
Merged
Conversation
- Merge if else into return - Merge .rotation and .position into .SetPositionAndRotation - Remove .ToString() call on strings - Use TryGetComponent to reduce garbage allocation - Merge .Where().Count() calls into .Count() call - Remove indirect gameObject call - Remove redundant null check - Use native .Count instead of LINQ method - Use faster string comparison
…nts' into perf/performance-improvements
simon-lemay-unity
approved these changes
Sep 22, 2022
Contributor
simon-lemay-unity
left a comment
There was a problem hiding this comment.
Fine with the change in UnityTransport. Haven't reviewed the rest.
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…y-Technologies#2204) * Performance Improvement - Merge if else into return - Merge .rotation and .position into .SetPositionAndRotation - Remove .ToString() call on strings - Use TryGetComponent to reduce garbage allocation - Merge .Where().Count() calls into .Count() call - Remove indirect gameObject call - Remove redundant null check - Use native .Count instead of LINQ method - Use faster string comparison * style: adjusting to code standards Co-authored-by: smitdylan2001 <dylan.smit01@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.unity3d.com/browse/MTT-4641
Changelog
Testing and Documentation
No functionality changed